Skip to content

Remove dfcc_utilst::make_map_start_address #7685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2023
Merged

Remove dfcc_utilst::make_map_start_address #7685

merged 1 commit into from
May 12, 2023

Conversation

tautschnig
Copy link
Collaborator

This method is never used.

This PR is only one of several possible cleanups of dfcc_utilst. I will, however, hold off on any further attempts (including this one, leaving it as draft) until #7541 is merged.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added cleanup Code Contracts Function and loop contracts labels Apr 24, 2023
@tautschnig tautschnig self-assigned this Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (535e6b2) 78.38% compared to head (71cc488) 78.55%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7685      +/-   ##
===========================================
+ Coverage    78.38%   78.55%   +0.16%     
===========================================
  Files         1686     1686              
  Lines       192915   192910       -5     
===========================================
+ Hits        151215   151539     +324     
+ Misses       41700    41371     -329
Impacted Files Coverage Δ
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 89.92% <ø> (+1.64%) ⬆️
...o-instrument/contracts/dynamic-frames/dfcc_utils.h 100.00% <ø> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig
Copy link
Collaborator Author

Will hold back on merging this until after #7541 is merged.

@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label May 1, 2023
@tautschnig tautschnig force-pushed the cleanup/remove-make_map_start_address branch from 0b7fe28 to 71cc488 Compare May 12, 2023 14:02
@tautschnig tautschnig marked this pull request as ready for review May 12, 2023 14:03
@tautschnig tautschnig merged commit 18bbc32 into diffblue:develop May 12, 2023
@tautschnig tautschnig deleted the cleanup/remove-make_map_start_address branch May 12, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-delmas-3000 remi-delmas-3000 remi-delmas-3000 approved these changes

@feliperodri feliperodri feliperodri approved these changes

Assignees

@tautschnig tautschnig

Labels
aws Bugs or features of importance to AWS CBMC users cleanup Code Contracts Function and loop contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tautschnig @remi-delmas-3000 @feliperodri